lkml.org 
[lkml]   [2015]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/5] spi: introduce mmap read support for spi flash devices
On Tue, Nov 03, 2015 at 03:36:10PM +0530, Vignesh R wrote:

> + }
> + mutex_lock(&master->mmap_lock_mutex);
> + ret = master->spi_mtd_mmap_read(spi, from, len, retlen, buf,
> + read_opcode, addr_width,
> + dummy_bytes);
> + mutex_unlock(&master->mmap_lock_mutex);
> + if (master->auto_runtime_pm)
> + pm_runtime_put(master->dev.parent);

It's a bit worrying that this doesn't sync with the message queue except
via the mutex: this means that we might be out of order with respect to
any asynchronous transfers that are happening on the device. I'm not
sure that this is a practical problem, though there is some risk of
unfair scheduling that would have to be under extreme load and it might
make sense to prioritise reads anyway.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-11-04 16:01    [W:0.117 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site