Messages in this thread | | | Date | Fri, 27 Nov 2015 14:33:40 -0800 | From | Brian Norris <> | Subject | Re: [PATCH] mtd: spi-nor: include mtd.h header for struct mtd_info definition |
| |
On Fri, Nov 27, 2015 at 10:25:55AM +0100, Rafał Miłecki wrote: > On 26 November 2015 at 09:05, Rafał Miłecki <zajec5@gmail.com> wrote: > > So far struct spi_nor was using just a pointer to struct mtd_info so it > > wasn't needed to have it fully defined there. After recent change we > > embed whole struct so we need to include a proper header.
Good catch.
> > Fixes: 1976367173a4 ("mtd: spi-nor: embed struct mtd_info within struct spi_nor")
I'm not 100% sure, but I thought I recall the -stable folks picking up for-linus commits just based on the 'Fixes:' tags. I feel like that isn't always ideal, though.
> > Signed-off-by: Rafał Miłecki <zajec5@gmail.com> > > This may be worth taking as a fix for 4.4. However I'm not aware of > any upstream driver failing to build because of this.
I don't see why it would need rushed out. All users of spi-nor.h currently include mtd.h first. So there are no build failures because of it.
Regards, Brian
| |