Messages in this thread | | | Subject | Re: [PATCH] scripts: fix the sys path for gdb scripts | From | yalin wang <> | Date | Fri, 27 Nov 2015 14:37:55 +0800 |
| |
> On Nov 25, 2015, at 15:38, Jan Kiszka <jan.kiszka@siemens.com> wrote: > > On 2015-11-19 11:54, yalin wang wrote: >> The sys.path should be scripts/gdb, >> so that we can import linux lib correctly. >> >> Signed-off-by: yalin wang <yalin.wang2010@gmail.com> >> --- >> scripts/gdb/vmlinux-gdb.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/gdb/vmlinux-gdb.py b/scripts/gdb/vmlinux-gdb.py >> index ce82bf5..5a45d1a 100644 >> --- a/scripts/gdb/vmlinux-gdb.py >> +++ b/scripts/gdb/vmlinux-gdb.py >> @@ -13,7 +13,7 @@ >> >> import os >> >> -sys.path.insert(0, os.path.dirname(__file__) + "/scripts/gdb") >> +sys.path.insert(0, os.path.dirname(__file__)) >> >> try: >> gdb.parse_and_eval("0") >> > > NACK. This patch is assuming that vmlinux-gdb.py is (only) started from > the scripts/gdb folder. But CONFIG_GDB_SCRIPTS places a link to > vmlinux-gdb.py aside the vmlinux binary in the top-level folder. That > way, the script is auto-loaded by gdb. > > If you have a compelling use case for loading the script manually from > its original folder, we can discuss augmenting the path. But removing > the existing one is wrong. > > Andrew, please drop the patch from your queue. > ok, i will send a V2 patch for this .
| |