lkml.org 
[lkml]   [2015]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] scripts: fix the sys path for gdb scripts
    From
    Date
    On 2015-11-19 11:54, yalin wang wrote:
    > The sys.path should be scripts/gdb,
    > so that we can import linux lib correctly.
    >
    > Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
    > ---
    > scripts/gdb/vmlinux-gdb.py | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/scripts/gdb/vmlinux-gdb.py b/scripts/gdb/vmlinux-gdb.py
    > index ce82bf5..5a45d1a 100644
    > --- a/scripts/gdb/vmlinux-gdb.py
    > +++ b/scripts/gdb/vmlinux-gdb.py
    > @@ -13,7 +13,7 @@
    >
    > import os
    >
    > -sys.path.insert(0, os.path.dirname(__file__) + "/scripts/gdb")
    > +sys.path.insert(0, os.path.dirname(__file__))
    >
    > try:
    > gdb.parse_and_eval("0")
    >

    NACK. This patch is assuming that vmlinux-gdb.py is (only) started from
    the scripts/gdb folder. But CONFIG_GDB_SCRIPTS places a link to
    vmlinux-gdb.py aside the vmlinux binary in the top-level folder. That
    way, the script is auto-loaded by gdb.

    If you have a compelling use case for loading the script manually from
    its original folder, we can discuss augmenting the path. But removing
    the existing one is wrong.

    Andrew, please drop the patch from your queue.

    Jan

    --
    Siemens AG, Corporate Technology, CT RTC ITP SES-DE
    Corporate Competence Center Embedded Linux


    \
     
     \ /
      Last update: 2015-11-25 09:01    [W:6.182 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site