Messages in this thread | | | Date | Tue, 24 Nov 2015 12:06:29 +0100 | From | Matias Bjørling <> | Subject | Re: [PATCH v2 4/5] lightnvm: release dev if dma pools fails |
| |
On 11/24/2015 11:34 AM, Sudip Mukherjee wrote: > If create_dma_pools() fails then we just returned the error code but we > missed freeing the device. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > drivers/lightnvm/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c > index d288996..9dd1623 100644 > --- a/drivers/lightnvm/core.c > +++ b/drivers/lightnvm/core.c > @@ -318,6 +318,7 @@ int nvm_register(struct request_queue *q, char *disk_name, > "ppalist"); > if (!dev->ppalist_pool) { > pr_err("nvm: could not create ppa pool\n"); > + nvm_free(dev); > return -ENOMEM; > } > } > Thanks Sudip. The nvm_free frees the registered manager. However, it should not be cleaned up if it failed. As nothing else is allocated after the registration.
| |