Messages in this thread Patch in this message | | | From | Sudip Mukherjee <> | Subject | [PATCH v2 2/5] lightnvm: check for max sector | Date | Tue, 24 Nov 2015 16:04:57 +0530 |
| |
If max_phys_sect is greater than 256 then its obviously greater than 1 so we will never hit the else-if block. And moreover, if we check for max_phys_sect at the end then it might happen that we initialize successfully only to see at the end that this is not supported. Lets check for max_phys_sect at the beginning and continue initialization only if it is supported.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- drivers/lightnvm/core.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index e338048..2ab561f 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -296,6 +296,11 @@ int nvm_register(struct request_queue *q, char *disk_name, if (!ops->identity) return -EINVAL; + if (ops->max_phys_sect > 256) { + pr_info("nvm: max sectors supported is 256.\n"); + return -EINVAL; + } + dev = kzalloc(sizeof(struct nvm_dev), GFP_KERNEL); if (!dev) return -ENOMEM; @@ -319,9 +324,6 @@ int nvm_register(struct request_queue *q, char *disk_name, pr_err("nvm: could not create ppa pool\n"); return -ENOMEM; } - } else if (dev->ops->max_phys_sect > 256) { - pr_info("nvm: max sectors supported is 256.\n"); - return -EINVAL; } return 0; -- 1.9.1
| |