Messages in this thread Patch in this message | | | From | Sudip Mukherjee <> | Subject | [PATCH] thermal: ti-soc-thermal: fix error check | Date | Mon, 23 Nov 2015 18:24:41 +0530 |
| |
We were only checking if data is not NULL but ti_bandgap_get_sensor_data() can return NULL or ERR_PTR.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c index b213a12..d76bb7c 100644 --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c @@ -365,7 +365,7 @@ int ti_thermal_remove_sensor(struct ti_bandgap *bgp, int id) data = ti_bandgap_get_sensor_data(bgp, id); - if (data && data->ti_thermal) { + if (!IS_ERR_OR_NULL(data) && data->ti_thermal) { if (data->our_zone) thermal_zone_device_unregister(data->ti_thermal); else -- 1.9.1
| |