Messages in this thread Patch in this message | | | From | Enric Balletbo i Serra <> | Subject | [PATCH 1/2] fs/pstore: Use memcpy_toio instead of memcpy | Date | Mon, 23 Nov 2015 10:53:23 +0100 |
| |
From: Furquan Shaikh <furquan@google.com>
persistent_ram_update uses vmap / iomap based on whether the buffer is in memory region or reserved region. However, both map it as non-cacheable memory. For armv8 specifically, non-cacheable mapping requests use a memory type that has to be accessed aligned to the request size. memcpy() doesn't guarantee that.
Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Olof Johansson <olofj@chromium.org> Tested-by: Furquan Shaikh <furquan@chromium.org> Signed-off-by: Enric Balletbo Serra <enric.balletbo@collabora.com> --- fs/pstore/ram_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c index 76c3f80..351164d 100644 --- a/fs/pstore/ram_core.c +++ b/fs/pstore/ram_core.c @@ -299,7 +299,7 @@ static void notrace persistent_ram_update(struct persistent_ram_zone *prz, const void *s, unsigned int start, unsigned int count) { struct persistent_ram_buffer *buffer = prz->buffer; - memcpy(buffer->data + start, s, count); + memcpy_toio(buffer->data + start, s, count); persistent_ram_update_ecc(prz, start, count); } -- 2.1.0
| |