Messages in this thread Patch in this message | | | From | Enric Balletbo i Serra <> | Subject | [PATCH 2/2] fs/pstore: Use memcpy_fromio() to save old ramoops buffer | Date | Mon, 23 Nov 2015 10:53:24 +0100 |
| |
From: Andrew Bresticker <abrestic@chromium.org>
The ramoops buffer may be mapped as either I/O memory or uncached memory. On ARM64, this results in a device-type (strongly-ordered) mapping. Since unnaligned accesses to device-type memory will generate an alignment fault (regardless of whether or not strict alignment checking is enabled), it is not safe to use memcpy(). memcpy_fromio() is guaranteed to only use aligned accesses, so use that instead.
Signed-off-by: Andrew Bresticker <abrestic@chromium.org> Reviewed-by: Puneet Kumar <puneetster@chromium.org> Signed-off-by: Enric Balletbo Serra <enric.balletbo@collabora.com> --- fs/pstore/ram_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c index 351164d..5308277 100644 --- a/fs/pstore/ram_core.c +++ b/fs/pstore/ram_core.c @@ -322,8 +322,8 @@ void persistent_ram_save_old(struct persistent_ram_zone *prz) } prz->old_log_size = size; - memcpy(prz->old_log, &buffer->data[start], size - start); - memcpy(prz->old_log + size - start, &buffer->data[0], start); + memcpy_fromio(prz->old_log, &buffer->data[start], size - start); + memcpy_fromio(prz->old_log + size - start, &buffer->data[0], start); } int notrace persistent_ram_write(struct persistent_ram_zone *prz, -- 2.1.0
| |