Messages in this thread | | | Date | Mon, 23 Nov 2015 10:16:18 +0100 | From | LABBE Corentin <> | Subject | Re: [linux-sunxi] [PATCH v2 2/5] clk: sunxi: Add driver for the H3 THS clock |
| |
On Mon, Nov 23, 2015 at 09:02:49AM +0100, Josef Gajdusek wrote: > This patch adds a driver for the THS clock which is present on the > Allwinner H3. > > Signed-off-by: Josef Gajdusek <atx@atx.name> > ---
Hello Just a minor comment below.
> +static void __init sun8i_h3_ths_clk_setup(struct device_node *node) > +{ > + struct clk *clk; > + struct clk_gate *gate; > + struct clk_divider *div; > + const char *parent; > + const char *clk_name = node->name; > + void __iomem *reg; > + int err; > + > + reg = of_io_request_and_map(node, 0, of_node_full_name(node)); > + > + if (IS_ERR(reg)) > + return; > + > + gate = kzalloc(sizeof(*gate), GFP_KERNEL); > + if (!gate) > + goto err_unmap; > + > + div = kzalloc(sizeof(*gate), GFP_KERNEL); copy/paste error, you mean sizeof(*div) ?
> + if (!div) > + goto err_gate_free; > + > + of_property_read_string(node, "clock-output-names", &clk_name);
Regards
| |