lkml.org 
[lkml]   [2015]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 0/7] Add spi-nor SPI transfer error handling
Hi Michal,

On Fri, Aug 14, 2015 at 09:23:06AM -0000, Michal Suchanek wrote:
> Hello,
>
> with these patches SPI transfer errors are not silently ignored but rather
> reported to spi-nor users.
>
> This should prevent silently dropping data to the floor in cases when the SPI
> transfer fails and the failure is detected.
>
> It has been pointed out that MTD users do not handle the case when data is read
> only partially so this version adds the last patch which handles this in
> spi-nor.
>
> Thanks
>
> Michal
>
> Michal Suchanek (7):
> mtd: spi-nor: change return value of read/write
> mtd: m25p80: return amount of data transferred or error in read/write
> mtd: fsl-quadspi: return amount of data read/written or error
> mtd: spi-nor: check return value from read/write
> mtd: spi-nor: stop passing around retlen

Patches 1 to 5 look good to me, though there is a new spi-nor driver
since you sent this. Can you rebase/fixup?

> mtd: spi-nor: simplify write loop
> mtd: spi-nor: add read loop

I posted some comments for these. I get the feeling that patch 6 is
over-complicated and should be just a simple assertion. And I'm still
not 100% sure on the approach for patch 7, since it's not clear whether
the responsibility lies in the SPI layer or in MTD.

Brian

> drivers/mtd/devices/m25p80.c | 33 +++++++++------
> drivers/mtd/spi-nor/fsl-quadspi.c | 29 ++++++-------
> drivers/mtd/spi-nor/spi-nor.c | 85 +++++++++++++++++++++++----------------
> include/linux/mtd/spi-nor.h | 8 ++--
> 4 files changed, 91 insertions(+), 64 deletions(-)
>
> --
> 2.1.4
>


\
 
 \ /
  Last update: 2015-11-20 01:01    [W:0.040 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site