Messages in this thread | | | Date | Thu, 19 Nov 2015 21:12:28 +0100 | From | Michael Büsch <> | Subject | [PATCH] m32r: Fix clearing of thread info fault code |
| |
The expression (~0 >> x) will always yield all-ones, because the right shift is an arithmetic right shift that will always shift ones in. Hence the old fault code bits will not be cleared before being ORed with the new fault code.
Fix this by forcing a logical right shift instead of an arithmetic right shift by using an unsigned long constant.
Reported-by: Ilia Mirkin <imirkin@alum.mit.edu> Signed-off-by: Michael Buesch <m@bues.ch>
---
The code also assumes sizeof(ti->flags) == 4. But that probably is ok for this arch.
This patch is untested, because I do not have the hardware.
Resend: Patch was originally sent on Wed, 18 Jun 2015.
[unhandled content-type:application/pgp-signature] | |