| Date | Thu, 19 Nov 2015 15:14:55 +0100 | From | Hannes Reinecke <> | Subject | Re: [PATCH 14/71] ncr5380: Use return instead of goto in NCR5380_select() |
| |
On 11/18/2015 09:35 AM, Finn Thain wrote: > The "failed" label in NCR5380_select() is not helpful. Some failures > return 0, others -1. Use return instead of goto to improve clarity and > brevity, like atari_NCR5380.c does. Fix the relevant comments. > > Signed-off-by: Finn Thain <fthain@telegraphics.com.au> > > --- > drivers/scsi/NCR5380.c | 30 ++++++++---------------------- > drivers/scsi/atari_NCR5380.c | 6 +++--- > 2 files changed, 11 insertions(+), 25 deletions(-) > Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
|