lkml.org 
[lkml]   [2015]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 76/71] ncr5380: Enable PDMA for DTC chips

    On Fri, 4 Dec 2015, Ondrej Zary wrote:

    > @@ -685,8 +684,10 @@ static inline int NCR5380_pwrite(struct Scsi_Host *instance, unsigned char *src,
    > /* All documentation says to check for this. Maybe my hardware is too
    > * fast. Waiting for it seems to work fine! KLL
    > */
    > - while (!(i = NCR5380_read(hostdata->c400_ctl_status) & CSR_GATED_53C80_IRQ))
    > + while (!(i = NCR5380_read(hostdata->c400_ctl_status) & CSR_GATED_53C80_IRQ)) {
    > + udelay(4); /* DTC436 chip hangs without this */
    > ; // FIXME - no timeout
    > + }
    >
    > /*
    > * I know. i is certainly != 0 here but the loop is new. See previous
    >

    Given that you've added braces, the redundant semicolon can be removed.

    --


    \
     
     \ /
      Last update: 2015-12-04 11:01    [W:6.529 / U:2.916 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site