| Subject | Re: [PATCH 7/9] IB/iser: Use a dedicated descriptor for login | From | Or Gerlitz <> | Date | Sun, 15 Nov 2015 11:14:13 +0200 |
| |
On 11/13/2015 3:46 PM, Christoph Hellwig wrote: > From: Sagi Grimberg<sagig@mellanox.com> > > Makes better sense and we'll need it later with CQ abstraction. > iser switch login bufs to void
Sagi, few quick comments on this patch, please address for next version..
The 2nd sentence of the change-log needs better phrasing.
also multiple checkpatch hits on the patch, please fix
CHECK: Please don't use multiple blank lines #26: FILE: drivers/infiniband/ulp/iser/iscsi_iser.h:329:
+
WARNING: __packed is preferred over __attribute__((packed)) #42: FILE: drivers/infiniband/ulp/iser/iscsi_iser.h:345: +} __attribute__((packed));
CHECK: Please don't use multiple blank lines #44: FILE: drivers/infiniband/ulp/iser/iscsi_iser.h:347: + +
CHECK: Alignment should match open parenthesis #161: FILE: drivers/infiniband/ulp/iser/iser_initiator.c:209: + if (ib_dma_mapping_error(device->ib_device, + desc->req_dma))
CHECK: Alignment should match open parenthesis #172: FILE: drivers/infiniband/ulp/iser/iser_initiator.c:220: + if (ib_dma_mapping_error(device->ib_device, + desc->rsp_dma))
|