Messages in this thread | | | Date | Wed, 18 Nov 2015 15:03:37 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 6/9] srp: use the new CQ API |
| |
On Tue, Nov 17, 2015 at 11:56:39AM -0800, Bart Van Assche wrote: > On 11/13/2015 05:46 AM, Christoph Hellwig wrote: >> +static void srp_inv_rkey_done(struct ib_cq *cq, struct ib_wc *wc) >> +{ >> + srp_handle_qp_err(cq, wc, "INV RKEY"); >> +} > > >> [ ... ] > > >> +static void srp_reg_mr_done(struct ib_cq *cq, struct ib_wc *wc) >> +{ >> + srp_handle_qp_err(cq, wc, "FAST REG"); >> +} > > How about using names like srp_inv_rkey_err() and srp_reg_mr_err() to make > clear that these completion functions are only called if an error occurred > ?
I can do that if you like.
| |