lkml.org 
[lkml]   [2015]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface
From
Date
Felipe Ferreri Tonello wrote:
> On 10/11/15 18:43, Sergei Shtylyov wrote:
>> On 11/10/2015 08:52 PM, Felipe F. Tonello wrote:
>>> @@ -75,6 +75,7 @@ struct f_midi {
>>> struct usb_ep *in_ep, *out_ep;
>>> struct snd_card *card;
>>> struct snd_rawmidi *rmidi;
>>> + u8 ms_id;
>>
>> Why 'ms_id' is not aligned with the above field names?
>
> It is actually aligned.

It's not in the original mail, which contains tab characters.

> Here is from my local git diff:
>
> @@ -75,6 +75,7 @@ struct f_midi {
> struct usb_ep *in_ep, *out_ep;
> struct snd_card *card;
> struct snd_rawmidi *rmidi;
> + u8 ms_id;

Apparently, you're using four spaces per tab. Linux uses eight.


Regards,
Clemens


\
 
 \ /
  Last update: 2015-11-13 09:41    [W:0.095 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site