lkml.org 
[lkml]   [2015]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface
From
Date
Hello.

On 11/11/2015 12:38 PM, Felipe Ferreri Tonello wrote:

>>> This avoids duplication of USB requests for OUT endpoint and
>>> re-enabling endpoints.
>>>
>>> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
>>> ---
>>> drivers/usb/gadget/function/f_midi.c | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/usb/gadget/function/f_midi.c
>>> b/drivers/usb/gadget/function/f_midi.c
>>> index 76ea53c..615d632 100644
>>> --- a/drivers/usb/gadget/function/f_midi.c
>>> +++ b/drivers/usb/gadget/function/f_midi.c
>>> @@ -75,6 +75,7 @@ struct f_midi {
>>> struct usb_ep *in_ep, *out_ep;
>>> struct snd_card *card;
>>> struct snd_rawmidi *rmidi;
>>> + u8 ms_id;
>>
>> Why 'ms_id' is not aligned with the above field names?
>
> It is actually aligned. Perhaps because of the +?

No, + should not affect this, it only affects things when a line doesn't
start with a tab.

> Here is from my local git diff:
>
> --- a/drivers/usb/gadget/function/f_midi.c
> +++ b/drivers/usb/gadget/function/f_midi.c
> @@ -75,6 +75,7 @@ struct f_midi {
> struct usb_ep *in_ep, *out_ep;
> struct snd_card *card;
> struct snd_rawmidi *rmidi;
> + u8 ms_id;

Unfortunately, tabs got replaces with spaces in this fragment.

[...]

MBR, Sergei



\
 
 \ /
  Last update: 2015-11-11 19:21    [W:0.094 / U:1.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site