lkml.org 
[lkml]   [2015]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] nfs:Fix error checking in the function nfs4_proc_setattr
From
On Fri, Nov 13, 2015 at 12:00 PM, Nicholas Krause <xerofoify@gmail.com> wrote:
> This fixes error checking in the function
> nfs4_proc_setattr to properly check and
> return a error code if the call to the
> function pnfs_commit_and_return_layout
> has failed by returning a error code
> as we cannot continue in the function
> nfs4_proc_settattr after this error
> code has been returned by the function,
> pnfs_commit_and_return.

Why not? It really is just advisory... On those architectures that
require it, the pNFS server still has a responsibility to recall any
outstanding layouts anyway when it receives a SETATTR call. The
pnfs_commit_and_return here should mainly be an optimisation to avoid
an unnecessary recall from the server, but we don't need to rely on
it.

Cheers
Trond


\
 
 \ /
  Last update: 2015-11-13 19:21    [W:0.021 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site