lkml.org 
[lkml]   [2015]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v2] clocksource/drivers/dw_apb_timer: Use {readl|writel}_relaxed
Date
The driver is safe to use the relaxed version. From another side, the
relaxed io accessor macros are available on all architectures now, so
we can use the relaxed versions to get a trivial overall system
performance improvement and reduce the latency a bit on some
architectures.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
since v1:
- correct the wrong sentence in commit msg about writel performance on
CA9 with outer L2 cache. Thank Arnd for pointing out this in another
thread
drivers/clocksource/dw_apb_timer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clocksource/dw_apb_timer.c b/drivers/clocksource/dw_apb_timer.c
index c76c750..04282ee 100644
--- a/drivers/clocksource/dw_apb_timer.c
+++ b/drivers/clocksource/dw_apb_timer.c
@@ -51,13 +51,13 @@ clocksource_to_dw_apb_clocksource(struct clocksource *cs)

static unsigned long apbt_readl(struct dw_apb_timer *timer, unsigned long offs)
{
- return readl(timer->base + offs);
+ return readl_relaxed(timer->base + offs);
}

static void apbt_writel(struct dw_apb_timer *timer, unsigned long val,
unsigned long offs)
{
- writel(val, timer->base + offs);
+ writel_relaxed(val, timer->base + offs);
}

static void apbt_disable_int(struct dw_apb_timer *timer)
--
2.6.2


\
 
 \ /
  Last update: 2015-11-13 14:01    [W:0.057 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site