Messages in this thread Patch in this message | | | From | yalin wang <> | Subject | [PATCH] mm: change may_enter_fs check condition | Date | Fri, 13 Nov 2015 19:47:35 +0800 |
| |
Add page_is_file_cache() for __GFP_FS check, otherwise, a Pageswapcache() && PageDirty() page can always be write back if the gfp flag is __GFP_FS, this is not the expected behavior.
Signed-off-by: yalin wang <yalin.wang2010@gmail.com> --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c index bd2918e..f8fc8c1 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -930,7 +930,7 @@ static unsigned long shrink_page_list(struct list_head *page_list, if (page_mapped(page) || PageSwapCache(page)) sc->nr_scanned++; - may_enter_fs = (sc->gfp_mask & __GFP_FS) || + may_enter_fs = (page_is_file_cache(page) && (sc->gfp_mask & __GFP_FS)) || (PageSwapCache(page) && (sc->gfp_mask & __GFP_IO)); /* -- 1.9.1
| |