Messages in this thread Patch in this message | | | From | Wang Nan <> | Subject | [PATCH] perf probe: Clear probe_trace_event when probe_trace_event failure | Date | Wed, 11 Nov 2015 10:19:43 +0000 |
| |
When failure occures in add_probe_trace_event(), to avoid potential dangling pointer and memory leak, resource attached to 'struct probe_trace_event' should be cleared.
Signed-off-by: Wang Nan <wangnan0@huawei.com> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Zefan Li <lizefan@huawei.com> Cc: pi3orama@163.com --- tools/perf/util/probe-finder.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c index bd8f03d..e9e37ca 100644 --- a/tools/perf/util/probe-finder.c +++ b/tools/perf/util/probe-finder.c @@ -1235,6 +1235,8 @@ static int add_probe_trace_event(Dwarf_Die *sc_die, struct probe_finder *pf) end: free(args); + if (ret) + clear_probe_trace_event(tev); return ret; } -- 1.8.3.4
| |