lkml.org 
[lkml]   [2015]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/17] fs/hpfs: remove unnecessary new_valid_dev check
On Thu, Oct 01, 2015 at 10:49:41PM +0200, Mikulas Patocka wrote:
>
>
> On Wed, 30 Sep 2015, Yaowei Bai wrote:
>
> > On Tue, Sep 29, 2015 at 05:03:24PM +0200, Mikulas Patocka wrote:
> > > Hi
> > >
> > > I suppose that you should remove the function new_valid_dev at all.
> >
> > Yes, i thought about that, but actually there's still a user of
> > new_valid_dev in fs/stat.c:
> >
> > #define valid_dev(x) choose_32_64(old_valid_dev,new_valid_dev)(x)
> >
> > so i just left new_valid_dev untouched and removed other users in fs first.
>
> So, remove that too - change it to choose_32_64(old_valid_dev(x),true)
>
> If you remove most calls for the function new_valid_dev, the function is
> meaningless and shouldn't be present in the source code.

Sorry for delay reply. OK, i will follow your advice and send another patch to
remove it once this patchset's taken by vfs or mm tree. Thanks for reviewing.

Yaowei

>
> Mikulas



\
 
 \ /
  Last update: 2015-10-08 14:41    [W:0.055 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site