lkml.org 
[lkml]   [2015]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/17] fs/hpfs: remove unnecessary new_valid_dev check


On Wed, 30 Sep 2015, Yaowei Bai wrote:

> On Tue, Sep 29, 2015 at 05:03:24PM +0200, Mikulas Patocka wrote:
> > Hi
> >
> > I suppose that you should remove the function new_valid_dev at all.
>
> Yes, i thought about that, but actually there's still a user of
> new_valid_dev in fs/stat.c:
>
> #define valid_dev(x) choose_32_64(old_valid_dev,new_valid_dev)(x)
>
> so i just left new_valid_dev untouched and removed other users in fs first.

So, remove that too - change it to choose_32_64(old_valid_dev(x),true)

If you remove most calls for the function new_valid_dev, the function is
meaningless and shouldn't be present in the source code.

Mikulas


\
 
 \ /
  Last update: 2015-10-01 23:21    [W:0.046 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site