lkml.org 
[lkml]   [2015]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 16/22] arm64/debug: Make use of the system wide safe value
On Mon, Oct 05, 2015 at 06:02:05PM +0100, Suzuki K. Poulose wrote:
> @@ -137,13 +138,17 @@ extern struct pmu perf_ops_bp;
> /* Determine number of BRP registers available. */
> static inline int get_num_brps(void)
> {
> - return ((read_cpuid(ID_AA64DFR0_EL1) >> 12) & 0xf) + 1;
> + return 1 +
> + cpuid_feature_extract_field(read_system_reg(SYS_ID_AA64DFR0_EL1),
> + ID_AA64DFR0_BRPS_SHIFT);
> }

cpuid_feature_extract_field() is fine but we should we bother with
read_system_reg vs just read_cpuid?

Similar question for patch 17/22.

--
Catalin


\
 
 \ /
  Last update: 2015-10-08 13:21    [W:0.312 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site