lkml.org 
[lkml]   [2015]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 12/22] arm64: Delay cpu feature checks
    From
    Date
    On 08/10/15 12:08, Catalin Marinas wrote:
    > On Mon, Oct 05, 2015 at 06:02:01PM +0100, Suzuki K. Poulose wrote:
    >> + /*
    >> + * second pass allows enable() invoked on active each CPU
    >> + * to consider interacting capabilities.
    >> + */
    >
    > This comment doesn't read properly.
    >

    Fixed locally

    >> + /*XXX: Are we really safe to call printk here ? */
    >> + pr_crit("FATAL: CPU%d is missing %s : %s \n",
    >> + smp_processor_id(), cap_type, cap->desc);
    >
    > I'm not sure it's safe either, basically we haven't fully brought the
    > CPU into the system.

    Btw, we already print "Booted secondary cpu" from secondary_start_kernel()
    before we trigger the notifiers. So I think it should be safe to call it
    at the moment.

    >
    >> + asm volatile(
    >> + " 1: wfe \n\t"
    >> + " b 1b\n"
    >> + );
    >> +}
    >
    > We could add a wfi as well in the mix.
    >
    > However, if we have PSCI, we should use it to park the CPUs back into
    > firmware (via cpu_operations.cpu_die), and only use the above loop if
    > that fails.

    Added cpu_die() and falls back to the trap as above.


    >
    >> +/*
    >> + * Run through the enabled system capabilities and enable() it on this CPU.
    >
    > s/it/them/
    >

    Fixed.

    Thanks
    Suzuki



    \
     
     \ /
      Last update: 2015-10-13 12:41    [W:4.477 / U:0.744 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site