Messages in this thread | | | Subject | Re: [PATCH v2] spi: Setup the master controller driver before setting the chipselect | From | Grygorii Strashko <> | Date | Tue, 27 Oct 2015 15:11:29 +0200 |
| |
On 10/27/2015 02:22 PM, Franklin S Cooper Jr. wrote: > > > On 10/16/2015 10:55 AM, Andy Shevchenko wrote: >> On Fri, Oct 16, 2015 at 6:47 PM, Franklin S Cooper Jr. <fcooper@ti.com> wrote: >>> >>> On 10/16/2015 10:45 AM, Andy Shevchenko wrote: >>>> On Fri, Oct 16, 2015 at 6:29 PM, Franklin S Cooper Jr <fcooper@ti.com> wrote: >>>>> SPI controllers may need to be properly setup before chip selects >>>>> can be used. Therefore, wait until the spi controller has a chance >>>>> to perform their setup procedure before trying to use the chip >>>>> select. >>>>> >>>>> This also insures that the chip selects pins are in a good >>>>> state before asseting them which otherwise may cause confusion. >>>>> >>>>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com> >>>> Does it mean I have to test it again? >>> Oops sorry. No the patch hasn't changed. I can shoot a v3 with your tested by included. >> Whatever Mark prefers. > Hi Mark, > I don't see that you pulled this patch into your topic/core branch just yet. Would you prefer > for me to shoot a v3 with Andy's tested by or will you just add it when your ready to > pull it in? > > Without this patch several of our boards don't boot in linux-next so if there is anything you > need for me to do please let me know. >> >> >
Boot tested on K2HK:
Tested-by: Grygorii Strashko <grygorii.strashko@ti.com> Tested-by: Ivan Khoronzhuk <ivan.khoronzhuk@lonaro.org>
-- regards, -grygorii
| |