Messages in this thread | | | Subject | Re: [PATCH 5/5] clk: scpi: add missing of_node_put | From | Sudeep Holla <> | Date | Thu, 22 Oct 2015 10:21:29 +0100 |
| |
On 21/10/15 21:41, Julia Lawall wrote: > for_each_available_child_of_node performs an of_node_get on each iteration, > so a break out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // <smpl> > @@ > expression root,e; > local idexpression child; > @@ > > for_each_available_child_of_node(root, child) { > ... when != of_node_put(child) > when != e = child > ( > return child; > | > + of_node_put(child); > ? return ...; > ) > ... > } > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Thanks for the fix.
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
PS: Since this driver is queued via arm-soc, it needs to go via them or wait for v4.4-rc1 and then queue via clk tree.
-- Regards, Sudeep
| |