Messages in this thread | | | Date | Wed, 21 Oct 2015 16:14:58 -0700 | From | Stephen Boyd <> | Subject | Re: [PATCH 2/5] clk: si5351: add missing of_node_put |
| |
On 10/21, Julia Lawall wrote: > for_each_child_of_node performs an of_node_get on each iteration, so > a break out of the loop requires an of_node_put. > > A simplified version of the semantic patch that fixes this problem is as > follows (http://coccinelle.lip6.fr): > > // <smpl> > @@ > expression root,e; > local idexpression child; > @@ > > for_each_child_of_node(root, child) { > ... when != of_node_put(child) > when != e = child > ( > return child; > | > + of_node_put(child); > ? return ...; > ) > ... > } > // </smpl> > > The resulting puts were manually moved to the end of the function for > conciseness. > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > ---
Applied to clk-next
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |