lkml.org 
[lkml]   [2015]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 2/2] ARM: dts: rockchip: Add the OTP gpio pinctrl
From
Caesar,

On Tue, Oct 20, 2015 at 7:43 PM, Caesar Wang <wxt@rock-chips.com> wrote:
> We need the OTP pin is gpio state before resetting the TSADC controller,
> since the tshut polarity will generate a high signal.

It might or might not be "high" depending on polarity, right? It's
just possible that it could glitch during probe. Other than that nit,
this seems fine to me.

If it's not too much trouble it'd be nice if you could spin with the
description change. Otherwise:

Reviewed-by: Douglas Anderson <dianders@chromium.org>


\
 
 \ /
  Last update: 2015-10-21 06:41    [W:0.080 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site