| Date | Fri, 2 Oct 2015 12:30:52 -0500 | From | Felipe Balbi <> | Subject | Re: [PATCH 05/14] RFC: usb/host/fotg210: change kmalloc by kmalloc_array |
| |
On Mon, Sep 21, 2015 at 05:01:09PM +0200, Peter Senna Tschudin wrote: > This patch change: > > kmalloc(DBG_SCHED_LIMIT * sizeof(*seen), GFP_ATOMIC) > > by: > > kmalloc_array(DBG_SCHED_LIMIT, sizeof(*seen), GFP_ATOMIC) > > as kmalloc_array() should be used for allocating arrays. > > Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
looks good to me
> --- > drivers/usb/host/fotg210-hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c > index 51feb61..e7e9991 100644 > --- a/drivers/usb/host/fotg210-hcd.c > +++ b/drivers/usb/host/fotg210-hcd.c > @@ -501,7 +501,7 @@ static ssize_t fill_periodic_buffer(struct debug_buffer *buf) > unsigned i; > __hc32 tag; > > - seen = kmalloc(DBG_SCHED_LIMIT * sizeof(*seen), GFP_ATOMIC); > + seen = kmalloc_array(DBG_SCHED_LIMIT, sizeof(*seen), GFP_ATOMIC); > if (!seen) > return 0; > > -- > 2.1.0 >
-- balbi [unhandled content-type:application/pgp-signature] |