Messages in this thread | | | Date | Fri, 2 Oct 2015 12:31:13 -0500 | From | Felipe Balbi <> | Subject | Re: [PATCH 06/14] RFC: usb/host/fotg210: replace msleep by usleep_range |
| |
On Mon, Sep 21, 2015 at 05:01:10PM +0200, Peter Senna Tschudin wrote: > msleep under 20ms can result in sleeping up to 20ms, which may not be > intended. Replace msleep(5) by usleep_range(5000, 6000). > > Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
good catch. I'd apply this straight away. Alan ?
> --- > drivers/usb/host/fotg210-hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c > index e7e9991..55c2279 100644 > --- a/drivers/usb/host/fotg210-hcd.c > +++ b/drivers/usb/host/fotg210-hcd.c > @@ -5122,7 +5122,7 @@ static int fotg210_run(struct usb_hcd *hcd) > fotg210->rh_state = FOTG210_RH_RUNNING; > /* unblock posted writes */ > fotg210_readl(fotg210, &fotg210->regs->command); > - msleep(5); > + usleep_range(5000, 6000); > up_write(&ehci_cf_port_reset_rwsem); > fotg210->last_periodic_enable = ktime_get_real(); > > -- > 2.1.0 >
-- balbi [unhandled content-type:application/pgp-signature] | |