lkml.org 
[lkml]   [2015]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
Subject[PATCH] ver_linux: reiserfsprogs.patch
The current implementation uses both 'grep' and 'awk' for text processing
here, which may be alright as a quick solution to be run on the command
line. While in a script, 'sed' or 'awk' would be a better choice. On
top of that, the current implementation expects the version number to
be found in the last field as seen by 'awk'. Should the output format
be different, this approach would no longer be reliable.

The proposed implementation uses 'sed' as a more flexible tool to handle
varying output formats.


Tested on:
Arch Linux

Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---

--- linux/scripts/ver_linux.orig 2015-08-30 21:34:09.000000000 +0300
+++ linux/scripts/ver_linux 2015-09-30 22:44:27.421829120 +0300
@@ -33,8 +33,13 @@
fsck.jfs -V 2>&1 | grep version | sed 's/,//' | awk \
'NR==1 {print "jfsutils ", $3}'

-reiserfsck -V 2>&1 | grep ^reiserfsck | awk \
-'NR==1{print "reiserfsprogs ", $2}'
+reiserfsck -V 2>&1 |
+sed '
+ /^reiserfsck/!d
+ s/[^0-9\.]//g
+ /^$/d
+ s/^/reiserfsprogs\t/
+'

fsck.reiser4 -V 2>&1 | grep ^fsck.reiser4 | awk \
'NR==1{print "reiser4progs ", $2}'

\
 
 \ /
  Last update: 2015-10-01 20:41    [W:0.022 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site