| Date | Fri, 09 Jan 2015 18:32:20 -0300 | From | Ezequiel Garcia <> | Subject | Re: [PATCH 3/6] UBI: Fastmap: Ensure that all fastmap work is done upon WL shutdown |
| |
On 11/24/2014 10:20 AM, Richard Weinberger wrote: > ...otherwise the deferred work might run after datastructures > got freed and corrupt memory. > > Signed-off-by: Richard Weinberger <richard@nod.at> > --- > drivers/mtd/ubi/wl.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c > index 7f135df..cb2e571 100644 > --- a/drivers/mtd/ubi/wl.c > +++ b/drivers/mtd/ubi/wl.c > @@ -2041,6 +2041,9 @@ static void protection_queue_destroy(struct ubi_device *ubi) > void ubi_wl_close(struct ubi_device *ubi) > { > dbg_wl("close the WL sub-system"); > +#ifdef CONFIG_MTD_UBI_FASTMAP > + flush_work(&ubi->fm_work); > +#endif > shutdown_work(ubi); > protection_queue_destroy(ubi); > tree_destroy(&ubi->used); >
IMHO, it's best to avoid nasty ifdefs like this (there are lots of ways of getting it cleaner). But I guess it's not a big deal. -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar
|