| Date | Wed, 17 Dec 2014 11:26:44 -0300 | From | Guido Martínez <> | Subject | Re: [PATCH 3/6] UBI: Fastmap: Ensure that all fastmap work is done upon WL shutdown |
| |
On Mon, Nov 24, 2014 at 02:20:33PM +0100, Richard Weinberger wrote: > ...otherwise the deferred work might run after datastructures > got freed and corrupt memory. > > Signed-off-by: Richard Weinberger <richard@nod.at>
After moving it to shutdown_work():
Reviewed-by: Guido Martínez <guido@vanguardiasur.com.ar>
> --- > drivers/mtd/ubi/wl.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c > index 7f135df..cb2e571 100644 > --- a/drivers/mtd/ubi/wl.c > +++ b/drivers/mtd/ubi/wl.c > @@ -2041,6 +2041,9 @@ static void protection_queue_destroy(struct ubi_device *ubi) > void ubi_wl_close(struct ubi_device *ubi) > { > dbg_wl("close the WL sub-system"); > +#ifdef CONFIG_MTD_UBI_FASTMAP > + flush_work(&ubi->fm_work); > +#endif > shutdown_work(ubi); > protection_queue_destroy(ubi); > tree_destroy(&ubi->used); > -- > 1.8.4.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
-- Guido Martínez, VanguardiaSur www.vanguardiasur.com.ar
|