Messages in this thread | | | Date | Thu, 29 Jan 2015 13:25:26 +0300 | From | Sergei Shtylyov <> | Subject | Re: [PATCH v3 5/5] usb: serial: implement CMSPAR for F81232 |
| |
Hello.
On 1/29/2015 5:01 AM, Peter Hung wrote:
> Hello.
Please don't top-post.
> I had using "scripts/checkpatch.pl -f" to scan original f81232.c. > It reported with "quoted string split across lines", so I merge these > 2 strings into 1 in patch 1/5.
Seems like another unrelated change...
> But it still warning with "line over 80 > character", so I had shorted string with this line.
Hm, the modern checkpatch.pl shouldn't warn about long lines due to string literals used in dev_err(), etc. calls.
> I will refine my patch set again with more attention.
In any case, don't leave the warnings till some next patch, fix them at once.
> Thanks for your advice.
WBR, Sergei
| |