lkml.org 
[lkml]   [2015]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/5] usb: serial: implement CMSPAR for F81232
Hello.

On 1/29/2015 5:01 AM, Peter Hung wrote:

> Hello.

Please don't top-post.

> I had using "scripts/checkpatch.pl -f" to scan original f81232.c.
> It reported with "quoted string split across lines", so I merge these
> 2 strings into 1 in patch 1/5.

Seems like another unrelated change...

> But it still warning with "line over 80
> character", so I had shorted string with this line.

Hm, the modern checkpatch.pl shouldn't warn about long lines due to string
literals used in dev_err(), etc. calls.

> I will refine my patch set again with more attention.

In any case, don't leave the warnings till some next patch, fix them at once.

> Thanks for your advice.

WBR, Sergei



\
 
 \ /
  Last update: 2015-01-29 11:41    [W:0.042 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site