lkml.org 
[lkml]   [2015]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/5] usb: serial: implement CMSPAR for F81232
Hello.

On 1/28/2015 8:58 AM, Peter Hung wrote:

> This patch implement CMSPAR in set_termios,
> and fix some warnning from checkpatch.pl

Please don't try to do 2 unrelated things in one patch.

> Signed-off-by: Peter Hung <hpeter+linux_kernel@gmail.com>
> ---
> drivers/usb/serial/f81232.c | 21 +++++++++++++++------
> 1 file changed, 15 insertions(+), 6 deletions(-)

> diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
> index 11a236b..79592d6 100644
> --- a/drivers/usb/serial/f81232.c
> +++ b/drivers/usb/serial/f81232.c
[...]
> @@ -361,12 +361,21 @@ static void f81232_set_termios(struct tty_struct *tty,
>
>
> if (cflag & PARENB) {
> - if (cflag & PARODD)
> - new_lcr |= UART_LCR_PARITY; /* odd */
> - else
> - new_lcr |= SERIAL_EVEN_PARITY; /* even */
> + if (cflag & CMSPAR) {
> + if (cflag & PARODD)
> + new_lcr |= (UART_LCR_PARITY | UART_LCR_SPAR);
> + else
> + new_lcr |= (SERIAL_EVEN_PARITY
> + | UART_LCR_SPAR);
> + } else {
> + if (cflag & PARODD)
> + new_lcr |= UART_LCR_PARITY; /* odd */
> + else
> + new_lcr |= SERIAL_EVEN_PARITY; /* even */
> + }
> }
>
> +

Not needed at all.

> if (cflag & CSTOPB)
> new_lcr |= UART_LCR_STOP;
> else
> @@ -445,7 +454,7 @@ static int f81232_open(struct tty_struct *tty, struct usb_serial_port *port)
>
> result = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL);
> if (result) {
> - dev_err(&port->dev, "failed submitting interrupt urb, error %d\n",
> + dev_err(&port->dev, "failed submitting urb, error %d\n",

What are you fixing here?

WBR, Sergei



\
 
 \ /
  Last update: 2015-01-29 03:01    [W:0.055 / U:21.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site