lkml.org 
[lkml]   [2015]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
On Sun, Jan 25, 2015 at 07:57:55PM +0800, Greg KH wrote:
> On Sat, Jan 24, 2015 at 10:20:53PM +0200, Heba Aamer wrote:
> > This patch fixes the following checkpatch.pl warning:
> > fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
> > dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
> >
> > netdev_info was used since it is a network subsystem
> >
> > Signed-off-by: Heba Aamer <heba93aamer@gmail.com>
> > ---
> > drivers/staging/rtl8712/usb_intf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
> > index 7d0d171..7748a75 100644
> > --- a/drivers/staging/rtl8712/usb_intf.c
> > +++ b/drivers/staging/rtl8712/usb_intf.c
> > @@ -366,7 +366,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
> > struct net_device *pnetdev;
> > struct usb_device *udev;
> >
> > - printk(KERN_INFO "r8712u: Staging version\n");
> > + netdev_info(pnetdev, "r8712u: Staging version\n");
> > /* In this probe function, O.S. will provide the usb interface pointer
> > * to driver. We have to increase the reference count of the usb device
> > * structure by using the usb_get_dev function.
>
> Please don't send patches that you do not at least test-build, it's a
> bit rude and wastes people's time.
>

Sorry Greg! I did build the module but it was cached. I built the
driver again after cleaning it, and I did find a warning related to
my patch. I had a question though, I found a warning related to an
unused function. Here is the warning:

drivers/staging/rtl8712/rtl871x_mp_ioctl.c:708:12: warning:
‘mp_query_drv_var’ defined but not used [-Wunused-function]

Should I remove this function or should I keep it as is?
If it will be removed, I will send it in a different patch.

> Oh, and also ensure that your patch is correct, hint, this one does not
> work at all :(

Sorry again and I will be sending the new patch soon.

>
> greg k-h

Heba Aamer


\
 
 \ /
  Last update: 2015-01-26 13:41    [W:0.059 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site