lkml.org 
[lkml]   [2015]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
On Sat, Jan 24, 2015 at 10:20:53PM +0200, Heba Aamer wrote:
> This patch fixes the following checkpatch.pl warning:
> fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
> dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
>
> netdev_info was used since it is a network subsystem
>
> Signed-off-by: Heba Aamer <heba93aamer@gmail.com>
> ---
> drivers/staging/rtl8712/usb_intf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
> index 7d0d171..7748a75 100644
> --- a/drivers/staging/rtl8712/usb_intf.c
> +++ b/drivers/staging/rtl8712/usb_intf.c
> @@ -366,7 +366,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
> struct net_device *pnetdev;
> struct usb_device *udev;
>
> - printk(KERN_INFO "r8712u: Staging version\n");
> + netdev_info(pnetdev, "r8712u: Staging version\n");
> /* In this probe function, O.S. will provide the usb interface pointer
> * to driver. We have to increase the reference count of the usb device
> * structure by using the usb_get_dev function.

Please don't send patches that you do not at least test-build, it's a
bit rude and wastes people's time.

Oh, and also ensure that your patch is correct, hint, this one does not
work at all :(

greg k-h


\
 
 \ /
  Last update: 2015-01-25 17:21    [W:0.160 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site