lkml.org 
[lkml]   [2015]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tpmdd-devel] Question about duplicate definitions of transmit_cmd in tpm-sysfs.c and tmp-interface.c
On Sat, Dec 27, 2014 at 01:34:51AM -0500, nick wrote:

> After reading the code and trying various ways to merge these
> functions into tpm.h. I am wondering if the merge is really a good
> idea as it seems to break a lot of code that is very hard to trace
> and redo correctly without a lot of work. Further more I am curious
> as to why the merge is even useful as it seems unneeded to me other
> then to unify the function definitions which seems a minor detail to
> me.

Jarkko has already sent a patch to merge them, I think you can see the
to be merged patch here:

https://github.com/PeterHuewe/linux-tpmdd/commit/6e01df24a659c5f21d6beabf9b7a20a85f470cf4

If you see a problem with it please remark..

Jason


\
 
 \ /
  Last update: 2015-01-02 08:21    [W:0.031 / U:2.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site