Messages in this thread Patch in this message | | | From | Azael Avalos <> | Subject | [PATCH] toshiba_acpi: Change sci_open function return value | Date | Wed, 14 Jan 2015 11:59:32 -0700 |
| |
Some Toshiba laptops have "poorly implemented" SCI calls on their BIOSes and are not checking for sci_{open, close} calls, therefore, the sci_open function is failing and making some of the supported features unavailable (kbd backlight, touchpad and illumination).
This patch changes the default return code of the sci_open function to return one instead of zero, making all those faulty laptops load all the supported features.
Signed-off-by: Azael Avalos <coproscefalo@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index fc34a71..71ac7c12 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c @@ -391,9 +391,10 @@ static int sci_open(struct toshiba_acpi_dev *dev) return 1; } else if (out[0] == TOS_NOT_PRESENT) { pr_info("Toshiba SCI is not present\n"); + return 0; } - return 0; + return 1; } static void sci_close(struct toshiba_acpi_dev *dev) -- 2.2.1
| |