lkml.org 
[lkml]   [2015]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging:vt6655 Add extern variable in head file
On Tue, Jan 13, 2015 at 04:31:14PM +0800, sun wang wrote:
> Extern variable must be declared in head file. Compiler can catch the inconsistency when variable changes.
>
> Signed-off-by: Sun Wang <sun.wxg@gmail.com>
> ---
> drivers/staging/vt6655/ioctl.c | 1 -
> drivers/staging/vt6655/ioctl.h | 5 +++++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/ioctl.c b/drivers/staging/vt6655/ioctl.c
> index 970e80d..716fc89 100644
> --- a/drivers/staging/vt6655/ioctl.c
> +++ b/drivers/staging/vt6655/ioctl.c
> @@ -31,7 +31,6 @@
> */
>
> #include "ioctl.h"
> -#include "iocmd.h"
> #include "mac.h"
> #include "card.h"
> #include "hostap.h"
> diff --git a/drivers/staging/vt6655/ioctl.h b/drivers/staging/vt6655/ioctl.h
> index 2dc5a57..42f6910 100644
> --- a/drivers/staging/vt6655/ioctl.h
> +++ b/drivers/staging/vt6655/ioctl.h
> @@ -30,6 +30,11 @@
> #define __IOCTL_H__
>
> #include "device.h"
> +#include "iocmd.h"
> +
> +#ifdef WPA_SM_Transtatus
> +extern SWPAResult wpa_Result;
> +#endif

I don't understand, what problem is this solving? This variable isn't
in the driver at all.

confused,

greg k-h


\
 
 \ /
  Last update: 2015-01-13 18:21    [W:0.089 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site