Messages in this thread Patch in this message | | | From | Markus Pargmann <> | Subject | [PATCH v2] regmap: Fix debugfs-file 'registers' mode | Date | Mon, 8 Sep 2014 08:43:37 +0200 |
| |
The macro "REGMAP_ALLOW_WRITE_DEBUGFS" can be used to enable write support on the registers file in the debugfs. The mode of the file is fixed to 0400 so it is not possible to write the file ever.
This patch fixes the mode by setting it to the correct value depending on the macro.
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com> Signed-off-by: Markus Pargmann <mpa@pengutronix.de> ---
Notes: Changes in v2: - Change registers_mode type to umode_t.
drivers/base/regmap/regmap-debugfs.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c index 625417e53bdd..d4e8a6f30c16 100644 --- a/drivers/base/regmap/regmap-debugfs.c +++ b/drivers/base/regmap/regmap-debugfs.c @@ -512,7 +512,14 @@ void regmap_debugfs_init(struct regmap *map, const char *name) map, ®map_reg_ranges_fops); if (map->max_register || regmap_readable(map, 0)) { - debugfs_create_file("registers", 0400, map->debugfs, + umode_t registers_mode; + + if (IS_ENABLED(REGMAP_ALLOW_WRITE_DEBUGFS)) + registers_mode = 0600; + else + registers_mode = 0400; + + debugfs_create_file("registers", registers_mode, map->debugfs, map, ®map_map_fops); debugfs_create_file("access", 0400, map->debugfs, map, ®map_access_fops); -- 2.1.0
| |