Messages in this thread | | | Date | Thu, 4 Sep 2014 09:39:58 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 1/1] PWM Backlight: Fix a bug which could cause the PWM backlight driver use the wrong PWM chip and fail the driver probing if multiple PWM chips exist. This defect could also cause the unintended PWM chip used and unaccessable by other drive |
| |
> I'm guessing this is your first patch. > > Please read: Documentation/SubmittingPatches > > A few notes for you search for and read about in the above document. > > - Subject line formatting (short, succinct) > - Commit logs (present, descriptive [what changed and why], succinct) > - Authorship (full/real names only)
You also need to CC linux-kernel@vger.kernel.org on all patches.
> > Signed-off-by: ryang <ryang@hach.com> > > --- > > drivers/video/backlight/pwm_bl.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c > > index b85983e..e0014a5 100644 > > --- a/drivers/video/backlight/pwm_bl.c > > +++ b/drivers/video/backlight/pwm_bl.c > > @@ -273,6 +273,9 @@ static int pwm_backlight_probe(struct platform_device *pdev) > > > > pb->pwm = devm_pwm_get(&pdev->dev, NULL); > > if (IS_ERR(pb->pwm)) { > > + ret = PTR_ERR(pb->pwm); > > + if (ret == -EPROBE_DEFER) > > + goto err_alloc; > > dev_err(&pdev->dev, "unable to request PWM, trying legacy API\n"); > > > > pb->pwm = pwm_request(data->pwm_id, "pwm-backlight"); >
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |