lkml.org 
[lkml]   [2014]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/2] x86: Quark: Add legacy_cache_size and TLB comments
On 01/10/14 01:11, Thomas Gleixner wrote:
> Bryan,
>
> On Wed, 1 Oct 2014, Bryan O'Donoghue wrote:
>
> what are you trying to achieve by sending out patches faster than
> anyone can review?

Thomas.

That's not the intention at all.

> Doing this has an obvious outcome:
>
> 1) The patches you whip up 10 seconds after the review hits your
> inbox are likely not to be well thought out. Neither are the
> changelogs.
>
> Just by skimming the lot I noticed at least two issues which you
> just mechanically fixed up without applying any thought. I'm not
> going to tell you, simply because you are starting to abuse and
> waste my time.
>
> 2) Keeping #1 as your modus operandi will make sure that you get on
> the backlog list of reviewers and maintainers and in the worst
> case on the shitlist.

1)
OK, I take your point on the frequency.

2)
On the substance.
I'm certainly not trying to antagonise you here - I assumed you were
*suggesting* to apply those comments directly ?
Which is why I updated the sent patches with your comments - since they
seemed more descriptive anyway - and sent back to the list.


Thanks,
Bryan


\
 
 \ /
  Last update: 2014-10-01 03:01    [W:0.049 / U:1.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site