Messages in this thread | | | From | "Ong, Boon Leong" <> | Subject | RE: [PATCH 2/2] x86: Quark: Comment setup_arch for TLB/PGE bugfix | Date | Wed, 1 Oct 2014 06:59:42 +0000 |
| |
> -----Original Message----- > From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- > owner@vger.kernel.org] On Behalf Of Bryan O'Donoghue > Sent: Wednesday, October 01, 2014 7:42 AM > To: tglx@linutronix.de; mingo@redhat.com; hpa@zytor.com; > davej@redhat.com; hmh@hmh.eng.br > Cc: x86@kernel.org; linux-kernel@vger.kernel.org; Bryan O'Donoghue > Subject: [PATCH 2/2] x86: Quark: Comment setup_arch for TLB/PGE bugfix > > Quark X1000 requires CR3 to be rewritten to flush TLB entries irrespective of > the PGE bits in CR4 or PTE.PGE > > Add a comment to setup_arch to indicate that the code > > load_cr3(swapper_pg_dir); > __flush_tlb_all(); > > Will already have flushed the TLB @ the CR3 reload allowing us to skip over a > potential if/else for Quark. > > This comment clearly states the bug, the behaviour we rely on and the reason > why we only do it this way - one time. > > Later on cpu_has_pge() will be false due to a fixup in > intel_init_early() and __flush_tlb_all() will work as expected from that point > onwards
s/intel_init_early/early_init_intel
| |