lkml.org 
[lkml]   [2014]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 10/10] blk-mq: support per-distpatch_queue flush machinery
From
On Wed, Sep 24, 2014 at 6:26 PM, Christoph Hellwig <hch@lst.de> wrote:
>> +struct blk_flush_queue *blk_alloc_flush_queue(struct request_queue *q,
>> + struct blk_mq_hw_ctx *hctx, int cmd_size)
>
> I still think this should pass in the numa node instead of the hctx, and
> allow node-local allocation for the old code as well.

We can do that, but have to pass NUMA_NO_NODE for old code
since blk_init_allocated_queue() doesn't provide node information
yet.

> As mentioned earlier
> initializing mq_flush_lock for the !mq case is harmless.

q->mq_ops is another friend for the purpose, :-)

>
> We also should document it where cleary somewhere that for devices that
> have flushes enabled ->init_request can be called for more requests than
> the queue depth, as drivers might allocate some sort of pool for them.

That does make sense.

Thanks,


\
 
 \ /
  Last update: 2014-09-24 18:01    [W:0.138 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site