lkml.org 
[lkml]   [2014]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 02/10] block: introduce blk_init_flush and its pair
On Mon, Sep 15, 2014 at 09:11:06PM +0800, Ming Lei wrote:
> These two temporary functions are introduced for holding flush
> initialization and de-initialization, so that we can
> introduce 'flush queue' easier in the following patch. And
> once 'flush queue' and its allocation/free functions are ready,
> they will be removed for sake of code readability.

Shouldn't we just do the mq work in this helper as well? blk_mq_init_flush
does exactly the same work, plus initializing a lock, which is harmless
for the !mq case as well.



\
 
 \ /
  Last update: 2014-09-24 13:01    [W:0.405 / U:0.836 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site