| Date | Wed, 24 Sep 2014 10:02:41 +0200 | Subject | Re: [RFC PATCH v2 12/16] input: gpio_keys_polled - Add support for GPIO descriptors | From | Linus Walleij <> |
| |
On Tue, Sep 16, 2014 at 1:52 PM, Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
> From: Aaron Lu <aaron.lu@intel.com> > > GPIO descriptors are the preferred way over legacy GPIO numbers > nowadays. Convert the driver to use GPIO descriptors internally but > still allow passing legacy GPIO numbers from platform data to support > existing platforms. > > Signed-off-by: Aaron Lu <aaron.lu@intel.com> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Great!
> #include <linux/gpio.h> > +#include <linux/gpio/consumer.h>
Again <linux/gpio.h> should not be needed anymore.
> + /* > + * Legacy GPIO number so request the GPIO here and > + * convert it to descriptor. > + */ > + if (!button->gpiod && gpio_is_valid(button->gpio)) { > + unsigned flags = 0; > + > + if (button->active_low) > + flags |= GPIOF_ACTIVE_LOW; > + > + error = devm_gpio_request_one(&pdev->dev, button->gpio, > + flags, button->desc ? : DRV_NAME); > + if (error) { > + dev_err(dev, "unable to claim gpio %u, err=%d\n", > + button->gpio, error); > + return error; > + } > + > + button->gpiod = gpio_to_desc(button->gpio);
So the field button->gpio is still there, this is a bit disturbing, but when I grep for it I see there is a multitude of users :-/
OK I guess these users have to be fixed one by one.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
|