Messages in this thread | | | Date | Mon, 1 Sep 2014 08:36:29 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH] scsi_debug: deadlock between completions and surprise module removal |
| |
> --- a/drivers/scsi/scsi_debug.c 2014-08-26 13:24:51.646948507 -0400 > +++ b/drivers/scsi/scsi_debug.c 2014-08-30 18:04:54.589226679 -0400 > @@ -2743,6 +2743,13 @@ static int stop_queued_cmnd(struct scsi_ > if (test_bit(k, queued_in_use_bm)) { > sqcp = &queued_arr[k]; > if (cmnd == sqcp->a_cmnd) { > + devip = (struct sdebug_dev_info *) > + cmnd->device->hostdata; > + if (devip) > + atomic_dec(&devip->num_in_q); > + sqcp->a_cmnd = NULL;
Why would the hostdata every be NULL here? We should never call ->slave_destroy on a device that has outstanding commands.
| |